execute-type param addition in GkeCodeExecutor #4111

SHRUTI6991 · 2026-01-10T00:49:29Z

Description:

Link to an existing issue (if applicable):

This PR updates the GkeCodeExecutor to add a new param called executor_type which takes either job / sandbox. Currently GkeCodeExecutor can only execute python code, so the changes made also focusses on executing ONLY python code via sandbox client.

Testing Plan

Unit Tests:

Addition of new Unit tests to verify forking of code between sandbox vs job.

[yes] I have added or updated unit tests for my change.
[yes] All unit tests pass locally.

Please include a summary of passed pytest results.

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
======================== 9 passed, 2 warnings in 2.72s =========================
Finished running tests!

Manual End-to-End (E2E) Tests:

Integration test by running a simple AI Agent: https://google.github.io/adk-docs/tools/google-cloud/gke-code-executor/ to write and execute Python code. The sandbox was connected via local tunnel for testing.

2026-01-10 00:46:28,105 - INFO - sandbox_client.py:159 - Creating SandboxClaim 'sandbox-claim-4d0f82e0' in namespace 'agent-sandbox-system' using template 'python-sandbox-template'...
2026-01-10 00:46:28,340 - INFO - sandbox_client.py:180 - Watching for Sandbox to become ready...
2026-01-10 00:46:39,284 - INFO - sandbox_client.py:208 - Sandbox sandbox-claim-4d0f82e0 is ready.
2026-01-10 00:46:39,285 - INFO - sandbox_client.py:243 - Starting Dev Mode tunnel: localhost:49605 -> svc/sandbox-router-svc:8080...
2026-01-10 00:46:39,288 - INFO - sandbox_client.py:259 - Waiting for port-forwarding to be ready...
2026-01-10 00:46:40,289 - INFO - sandbox_client.py:271 - Dev Mode ready. Tunneled to Router at http://127.0.0.1:49605
2026-01-10 00:46:40,790 - INFO - gke_code_executor.py:156 - Executing code in sandbox:

def fibonacci(n):
  """
  This function calculates the nth Fibonacci number.

  Args:
    n: The index of the Fibonacci number to calculate (starting from 0).

  Returns:
    The nth Fibonacci number.
  """
  if n <= 0:
    return 0
  elif n == 1:
    return 1
  else:
    a = 0
    b = 1
    for _ in range(2, n + 1):
      c = a + b
      a = b
      b = c
    return b

# Get the first fibonacci number (index 0)
first_fibonacci = fibonacci(0) 

# Print the first fibonacci number
print(first_fibonacci)

2026-01-10 00:46:40,958 - INFO - sandbox_client.py:464 - File 'script.py' uploaded successfully.
2026-01-10 00:46:41,031 - INFO - sandbox_client.py:356 - Stopping port-forwarding...
2026-01-10 00:46:41,034 - INFO - sandbox_client.py:368 - Deleting SandboxClaim: sandbox-claim-4d0f82e0

Output:

Checklist

[ yes] I have read the CONTRIBUTING.md document.
[yes] I have performed a self-review of my own code.
[yes] I have commented my code, particularly in hard-to-understand areas.
[yes] I have added tests that prove my fix is effective or that my feature works.
[yes] New and existing unit tests pass locally with my changes.
[yes] I have manually tested my changes end-to-end.
[yes] Any dependent changes have been merged and published in downstream modules.

Additional context

Add any other context or screenshots about the feature request here.

…tor.

gemini-code-assist · 2026-01-10T00:49:47Z

Summary of Changes

Hello @SHRUTI6991, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the GkeCodeExecutor by introducing a new executor_type configuration, enabling a choice between traditional Kubernetes Job-based execution and a new, more isolated sandbox environment. This change provides greater flexibility and security for running code, initially focusing on Python code within the sandbox, and lays the groundwork for future expansion of execution methods.

Highlights

Flexible Execution: Introduced an executor_type parameter in GkeCodeExecutor allowing users to choose between "job" (Kubernetes Job) and "sandbox" for code execution.
Sandbox Integration: Integrated the agentic_sandbox client to enable secure, sandboxed execution of Python code, addressing the current limitation of GkeCodeExecutor.
Code Refactoring: The core execute_code method was refactored into _execute_in_sandbox and _execute_as_job to cleanly separate execution logic based on the chosen executor_type.
Expanded Test Coverage: New unit tests were added to specifically verify the correct routing of code execution based on the executor_type parameter, ensuring both sandbox and job paths are correctly handled.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request introduces a new execution path in GkeCodeExecutor to use agentic-sandbox, controlled by a new executor_type parameter. The changes are logical and the addition of unit tests for the new branching logic is great. My feedback focuses on improving robustness, configurability, and code quality. Key suggestions include pinning the new git dependency for build stability, making the sandbox template name configurable, ensuring consistent logger usage, fixing a potential type error, and making the executor type selection logic more robust.

pyproject.toml

src/google/adk/code_executors/gke_code_executor.py

tests/unittests/code_executors/test_gke_code_executor.py

vicentefb

The separation between the Job and Sandbox logic is clean. I have just a few comments.

src/google/adk/code_executors/gke_code_executor.py

ryanaiagent · 2026-01-16T16:45:37Z

Hi @SHRUTI6991, Thank you for your contribution! We appreciate you taking the time to submit this pull request.
Can you please fix the formatting errors.

src/google/adk/code_executors/gke_code_executor.py

ryanaiagent · 2026-01-20T18:09:45Z

/gemini review

gemini-code-assist

Code Review

This pull request successfully introduces a new sandbox execution mode to the GkeCodeExecutor, enhancing its capabilities to execute Python code using the agentic_sandbox client. The changes include adding the necessary dependency, updating the class with new configuration options, and refactoring the execution logic to route requests based on the chosen executor type. The addition of comprehensive unit tests for the new functionality, including error handling and execution routing, is commendable and ensures the reliability of the new feature. Overall, the changes are well-implemented and significantly improve the flexibility of the GkeCodeExecutor.

gemini-code-assist · 2026-01-20T18:11:25Z

pyproject.toml

  # go/keep-sorted start
  "PyYAML>=6.0.2, <7.0.0",                                   # For APIHubToolset.
  "aiosqlite>=0.21.0",                                       # For SQLite database
+  "agentic_sandbox @ git+https://github.com/kubernetes-sigs/agent-sandbox.git@dbac66ecba5497ac493ca5e4ab5e0fcb1c945134#subdirectory=clients/python/agentic-sandbox-client", # For Agent Sandboxed Code Execution


Using a direct Git URL with a specific commit hash for a dependency can make dependency management and updates challenging. It ties the project to an immutable state of the external repository, which might not receive updates or security patches easily. Consider if there's a way to depend on a published package with version ranges, or if this is a temporary measure, document the long-term plan for this dependency.

Is there a plan to transition this to a versioned release instead of a direct Git dependency to a specific commit?

Yes, we are going to publish the python client to PyPI. This is an interim solution.

src/google/adk/code_executors/gke_code_executor.py

ryanaiagent · 2026-01-20T18:25:14Z

Hi @SHRUTI6991 , can you please fix the failing unit tests.

ryanaiagent · 2026-01-20T21:23:09Z

Hi @SHRUTI6991 , looks like the unit test failures are not related to your code.

SHRUTI6991 · 2026-01-21T17:26:48Z

@ryanaiagent I have addressed the comment. Ptal.

ryanaiagent · 2026-01-23T02:47:59Z

Hi @SHRUTI6991 , Your PR has been received by the team and is currently under review. We will provide feedback as soon as we have an update to share.

ryanaiagent · 2026-01-23T02:48:29Z

Hi @sasha-gitg , can you please review this.

SHRUTI6991 added 2 commits January 9, 2026 23:44

Add initial implementation to take in executor_type in gke_code_execu…

0b28736

…tor.

Fix extension name.

cf9a092

adk-bot added the tools [Component] This issue is related to tools label Jan 10, 2026

gemini-code-assist bot reviewed Jan 10, 2026

View reviewed changes

Address gemini comments to fix the dependency.

d5351f3

SHRUTI6991 changed the title ~~Execute type/param addition in GkeCodeExecutor~~ execute-type param addition in GkeCodeExecutor Jan 12, 2026

vicentefb reviewed Jan 14, 2026

View reviewed changes

src/google/adk/code_executors/gke_code_executor.py Show resolved Hide resolved

vicentefb reviewed Jan 14, 2026

View reviewed changes

src/google/adk/code_executors/gke_code_executor.py Outdated Show resolved Hide resolved

vicentefb reviewed Jan 14, 2026

View reviewed changes

src/google/adk/code_executors/gke_code_executor.py Outdated Show resolved Hide resolved

vicentefb reviewed Jan 14, 2026

View reviewed changes

tests/unittests/code_executors/test_gke_code_executor.py Show resolved Hide resolved

vicentefb suggested changes Jan 14, 2026

View reviewed changes

Address comments to add logging and validation.

ac876c5

SHRUTI6991 marked this pull request as ready for review January 15, 2026 18:16

igooch reviewed Jan 16, 2026

View reviewed changes

src/google/adk/code_executors/gke_code_executor.py Outdated Show resolved Hide resolved

src/google/adk/code_executors/gke_code_executor.py Outdated Show resolved Hide resolved

ryanaiagent self-assigned this Jan 16, 2026

ryanaiagent added the request clarification [Status] The maintainer need clarification or more information from the author label Jan 16, 2026

SHRUTI6991 and others added 4 commits January 16, 2026 16:47

Address comments to reflect changes the class comment block.

9d1fd94

Correct format for the failed format checks.

d9247be

Merge branch 'main' into execute-type/param-addition

8c9dbd3

Correct comment block.

f183e80

tomergee reviewed Jan 20, 2026

View reviewed changes

src/google/adk/code_executors/gke_code_executor.py Outdated Show resolved Hide resolved

gemini-code-assist bot reviewed Jan 20, 2026

View reviewed changes

ryanaiagent removed the request clarification [Status] The maintainer need clarification or more information from the author label Jan 20, 2026

SHRUTI6991 and others added 2 commits January 21, 2026 08:59

Merge branch 'main' into execute-type/param-addition

72dbf2d

Add stderr to raise errors from sandbox failures.

8a2a844

ryanaiagent added the needs review [Status] The PR/issue is awaiting review from the maintainer label Jan 23, 2026

execute-type param addition in GkeCodeExecutor #4111

Are you sure you want to change the base?

execute-type param addition in GkeCodeExecutor #4111

Uh oh!

Conversation

SHRUTI6991 commented Jan 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Testing Plan

Checklist

Additional context

Uh oh!

gemini-code-assist bot commented Jan 10, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vicentefb left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ryanaiagent commented Jan 16, 2026

Uh oh!

Uh oh!

ryanaiagent commented Jan 20, 2026

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

ryanaiagent Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

SHRUTI6991 Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ryanaiagent commented Jan 20, 2026

Uh oh!

ryanaiagent commented Jan 20, 2026

Uh oh!

SHRUTI6991 commented Jan 21, 2026

Uh oh!

ryanaiagent commented Jan 23, 2026

Uh oh!

ryanaiagent commented Jan 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

SHRUTI6991 commented Jan 10, 2026 •

edited

Loading